Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

monitor: don't call pselect() on deleted sysfs files 

It makes no sense to listen for events on files that have
been deleted. This happens when arrays are stopped and the
kernel removes the associated sysfs structures.

Calling pselect() on the deleted attributes may cause a storm
of wake events.

Signed-off-by: Martin Wilck <mwilck@arcor.de>
Signed-off-by: NeilBrown <neilb@suse.de>
This commit is contained in:
mwilck@arcor.de 2013-10-25 12:07:36 +02:00 committed by NeilBrown
parent 7d5a7ff3da
commit 2b60d2890f
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
monitor.c
View File

@ -38,8 +38,17 @@ static int write_attr(char *attr, int fd)
static void add_fd(fd_set *fds, int *maxfd, int fd)
{
struct stat st;
if (fd < 0)
return;
if (fstat(fd, &st) == -1) {
dprintf("%s: Invalid fd %d\n", __func__, fd);
return;
}
if (st.st_nlink == 0) {
dprintf("%s: fd %d was deleted\n", __func__, fd);
return;
}
if (fd > *maxfd)
*maxfd = fd;
FD_SET(fd, fds);