Remove code duplication in SyncthingApplet

This commit is contained in:
Martchus 2019-08-01 19:08:58 +02:00
parent 2363e9a7d4
commit 1982d26295
1 changed files with 8 additions and 11 deletions

View File

@ -343,12 +343,14 @@ void SyncthingApplet::showNotificationsDialog()
void SyncthingApplet::dismissNotifications()
{
m_connection.considerAllNotificationsRead();
if (!m_notifications.empty()) {
m_notifications.clear();
emit notificationsAvailableChanged(false);
// update status as well because having or not having notifications is relevant for status text/icon
updateStatusIconAndTooltip();
if (m_notifications.empty()) {
return;
}
m_notifications.clear();
emit notificationsAvailableChanged(false);
// update status as well because having or not having notifications is relevant for status text/icon
updateStatusIconAndTooltip();
}
void SyncthingApplet::showInternalErrorsDialog()
@ -428,13 +430,8 @@ void SyncthingApplet::handleConnectionStatusChanged(Data::SyncthingStatus previo
return;
}
// update whether passive
setPassive(static_cast<int>(newStatus) < passiveStates().size() && passiveStates().at(static_cast<int>(newStatus)).isChecked());
// update status icon and tooltip text
m_statusInfo.updateConnectionStatus(m_connection);
m_statusInfo.updateConnectedDevices(m_connection);
emit connectionStatusChanged();
updateStatusIconAndTooltip();
}
void SyncthingApplet::handleDevicesChanged()