Martchus
/
syncthingtray
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Improve pauseResumeDirectory() 

* Use compact JSON
* Don't do anything if no dirs specified
* Note Syncthing issue
This commit is contained in:
Martchus 2017-02-23 23:10:58 +01:00
parent 189a985e23
commit 8332176bf6
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
connector/syncthingconnection.cpp
View File

@ -456,9 +456,15 @@ QNetworkReply *SyncthingConnection::postData(const QString &path, const QUrlQuer
/*!
* \brief Internally used to pause/resume directories.
* \returns Returns whether a request has been made.
* \remarks This might currently result in errors caused by Syncthing not
* handling E notation correctly:
* https://github.com/syncthing/syncthing/issues/4001
*/
bool SyncthingConnection::pauseResumeDirectory(const QStringList &dirIds, bool paused)
{
if(dirIds.isEmpty()) {
return false;
}
if(!isConnected()) {
emit error(tr("Unable to pause/resume a directories when not connected"), SyncthingErrorCategory::SpecificRequest, QNetworkReply::NoError);
return false;
@ -468,7 +474,7 @@ bool SyncthingConnection::pauseResumeDirectory(const QStringList &dirIds, bool p
if(setPaused(config, dirIds, paused)) {
QJsonDocument doc;
doc.setObject(config);
QNetworkReply *reply = postData(QStringLiteral("system/config"), QUrlQuery(), doc.toJson());
QNetworkReply *reply = postData(QStringLiteral("system/config"), QUrlQuery(), doc.toJson(QJsonDocument::Compact));
reply->setProperty("dirIds", dirIds);
reply->setProperty("resume", !paused);
QObject::connect(reply, &QNetworkReply::finished, this, &SyncthingConnection::readDirPauseResume);