Martchus
/
tageditor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix passing/livetime of AbortableProgressFeedback in TagEditorWidget::startParsing()

This commit is contained in:
Martchus 2021-02-15 23:45:39 +01:00
parent e3eff819ec
commit 1a2427d1dc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gui/tageditorwidget.cpp
View File

@ -832,14 +832,13 @@ bool TagEditorWidget::startParsing(const QString &path, bool forceRefresh)
// write diagnostics to m_diagReparsing if making results are avalable
m_makingResultsAvailable &= sameFile;
Diagnostics &diag = m_makingResultsAvailable ? m_diagReparsing : m_diag;
AbortableProgressFeedback progress; // FIXME: actually use the progress object
// clear diagnostics
diag.clear();
m_diagReparsing.clear();
// show filename
m_ui->fileNameLabel->setText(m_fileName);
// define function to parse the file
const auto startThread = [this, &diag, &progress] {
const auto startThread = [this, &diag] {
char result;
try {
// try to open with write access
@ -849,6 +848,7 @@ bool TagEditorWidget::startParsing(const QString &path, bool forceRefresh)
// try to open read-only if opening with write access failed
m_fileInfo.reopen(true);
}
AbortableProgressFeedback progress; // FIXME: actually use the progress object
m_fileInfo.setForceFullParse(Settings::values().editor.forceFullParse);
m_fileInfo.parseEverything(diag, progress);
result = ParsingSuccessful;