Use override

This commit is contained in:
Martchus 2019-06-01 12:45:12 +02:00
parent 54315a3739
commit de558048ce
20 changed files with 58 additions and 58 deletions

View File

@ -58,11 +58,11 @@ public:
bool isFetchingCover() const; bool isFetchingCover() const;
TagParser::TagValue fieldValue(int row, TagParser::KnownField knownField) const; TagParser::TagValue fieldValue(int row, TagParser::KnownField knownField) const;
QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const; QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
Qt::ItemFlags flags(const QModelIndex &index) const; Qt::ItemFlags flags(const QModelIndex &index) const override;
QVariant headerData(int section, Qt::Orientation orientation, int role) const; QVariant headerData(int section, Qt::Orientation orientation, int role) const override;
int rowCount(const QModelIndex &parent = QModelIndex()) const; int rowCount(const QModelIndex &parent = QModelIndex()) const override;
int columnCount(const QModelIndex &parent = QModelIndex()) const; int columnCount(const QModelIndex &parent = QModelIndex()) const override;
const QByteArray *cover(const QModelIndex &index) const; const QByteArray *cover(const QModelIndex &index) const;
virtual bool fetchCover(const QModelIndex &index); virtual bool fetchCover(const QModelIndex &index);
const QString *lyrics(const QModelIndex &index) const; const QString *lyrics(const QModelIndex &index) const;

View File

@ -23,7 +23,7 @@ class AttachmentsEdit : public QWidget {
public: public:
explicit AttachmentsEdit(TagParser::MediaFileInfo *fileInfo, QWidget *parent = nullptr); explicit AttachmentsEdit(TagParser::MediaFileInfo *fileInfo, QWidget *parent = nullptr);
~AttachmentsEdit(); ~AttachmentsEdit() override;
TagParser::MediaFileInfo *fileInfo(); TagParser::MediaFileInfo *fileInfo();
void setFileInfo(TagParser::MediaFileInfo *fileInfo, bool updateUi = true); void setFileInfo(TagParser::MediaFileInfo *fileInfo, bool updateUi = true);

View File

@ -43,17 +43,17 @@ class AttachmentsModel : public QAbstractTableModel {
Q_OBJECT Q_OBJECT
public: public:
AttachmentsModel(QObject *parent = nullptr); AttachmentsModel(QObject *parent = nullptr);
~AttachmentsModel(); ~AttachmentsModel() override;
QVariant data(const QModelIndex &index, int role) const; QVariant data(const QModelIndex &index, int role) const override;
bool setData(const QModelIndex &index, const QVariant &value, int role); bool setData(const QModelIndex &index, const QVariant &value, int role) override;
Qt::ItemFlags flags(const QModelIndex &index) const; Qt::ItemFlags flags(const QModelIndex &index) const override;
QVariant headerData(int section, Qt::Orientation orientation, int role) const; QVariant headerData(int section, Qt::Orientation orientation, int role) const override;
int rowCount(const QModelIndex &parent = QModelIndex()) const; int rowCount(const QModelIndex &parent = QModelIndex()) const override;
int columnCount(const QModelIndex &parent = QModelIndex()) const; int columnCount(const QModelIndex &parent = QModelIndex()) const override;
void revert(); void revert() override;
bool submit(); bool submit() override;
void repealSelection(); void repealSelection();
TagParser::AbstractAttachment *attachment(const QModelIndex &index); TagParser::AbstractAttachment *attachment(const QModelIndex &index);

View File

@ -8,13 +8,13 @@ namespace QtGui {
class CodeEdit : public QPlainTextEdit { class CodeEdit : public QPlainTextEdit {
public: public:
CodeEdit(QWidget *parent = nullptr); CodeEdit(QWidget *parent = nullptr);
~CodeEdit(); ~CodeEdit() override;
const QString &indentation() const; const QString &indentation() const;
void setIndentation(const QString &indentation); void setIndentation(const QString &indentation);
protected: protected:
void keyPressEvent(QKeyEvent *e); void keyPressEvent(QKeyEvent *e) override;
private: private:
void handleReturn(QKeyEvent *e); void handleReturn(QKeyEvent *e);

View File

@ -29,7 +29,7 @@ class DbQueryWidget : public QWidget {
public: public:
explicit DbQueryWidget(TagEditorWidget *tagEditorWidget, QWidget *parent = nullptr); explicit DbQueryWidget(TagEditorWidget *tagEditorWidget, QWidget *parent = nullptr);
~DbQueryWidget(); ~DbQueryWidget() override;
void insertSearchTermsFromTagEdit(TagEdit *tagEdit, bool songSpecific = false); void insertSearchTermsFromTagEdit(TagEdit *tagEdit, bool songSpecific = false);
SongDescription currentSongDescription() const; SongDescription currentSongDescription() const;
@ -63,7 +63,7 @@ private slots:
void showLyricsFromIndex(const QModelIndex &index); void showLyricsFromIndex(const QModelIndex &index);
protected: protected:
bool eventFilter(QObject *obj, QEvent *event); bool eventFilter(QObject *obj, QEvent *event) override;
private: private:
void useQueryResults(QueryResultsModel *queryResults); void useQueryResults(QueryResultsModel *queryResults);

View File

@ -28,7 +28,7 @@ class EnterTargetDialog : public QDialog {
public: public:
explicit EnterTargetDialog(QWidget *parent = nullptr); explicit EnterTargetDialog(QWidget *parent = nullptr);
~EnterTargetDialog(); ~EnterTargetDialog() override;
TagParser::TagTarget target() const; TagParser::TagTarget target() const;
void setTarget(const TagParser::TagTarget &target, const TagParser::MediaFileInfo *file = nullptr); void setTarget(const TagParser::TagTarget &target, const TagParser::MediaFileInfo *file = nullptr);

View File

@ -21,8 +21,8 @@ public:
bool isFileAccepted(const QString &path) const; bool isFileAccepted(const QString &path) const;
protected: protected:
virtual bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const; bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const override;
void sort(int column, Qt::SortOrder order = Qt::AscendingOrder); void sort(int column, Qt::SortOrder order = Qt::AscendingOrder) override;
private: private:
bool m_filterEnabled; bool m_filterEnabled;

View File

@ -18,7 +18,7 @@ class FileInfoModel : public QStandardItemModel {
public: public:
explicit FileInfoModel(QObject *parent = nullptr); explicit FileInfoModel(QObject *parent = nullptr);
QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const; QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const override;
const TagParser::MediaFileInfo *fileInfo() const; const TagParser::MediaFileInfo *fileInfo() const;
void setFileInfo(TagParser::MediaFileInfo &fileInfo, TagParser::Diagnostics &diag, TagParser::Diagnostics *diagReparsing = nullptr); void setFileInfo(TagParser::MediaFileInfo &fileInfo, TagParser::Diagnostics &diag, TagParser::Diagnostics *diagReparsing = nullptr);

View File

@ -39,7 +39,7 @@ class MainWindow : public QMainWindow {
public: public:
explicit MainWindow(QWidget *parent = nullptr); explicit MainWindow(QWidget *parent = nullptr);
~MainWindow(); ~MainWindow() override;
// file browser // file browser
QString currentDirectory() const; QString currentDirectory() const;
@ -52,7 +52,7 @@ public slots:
void startParsing(const QString &path); void startParsing(const QString &path);
protected: protected:
bool event(QEvent *event); bool event(QEvent *event) override;
private slots: private slots:
// file selection // file selection

View File

@ -11,8 +11,8 @@ public:
explicit MinimumEmptySpinBox(QWidget *parent = nullptr); explicit MinimumEmptySpinBox(QWidget *parent = nullptr);
protected: protected:
virtual int valueFromText(const QString &text) const; int valueFromText(const QString &text) const override;
virtual QString textFromValue(int val) const; QString textFromValue(int val) const override;
}; };
} // namespace QtGui } // namespace QtGui

View File

@ -38,8 +38,8 @@ public:
std::size_t maxLineCount() const; std::size_t maxLineCount() const;
std::size_t currentLineCount() const; std::size_t currentLineCount() const;
virtual QSize sizeHint() const; QSize sizeHint() const override;
virtual QSize minimumSizeHint() const; QSize minimumSizeHint() const override;
public slots: public slots:
void setText(const QString &text); void setText(const QString &text);
@ -54,8 +54,8 @@ public slots:
void setMaxLineCount(std::size_t maxLineCount); void setMaxLineCount(std::size_t maxLineCount);
protected: protected:
void paintEvent(QPaintEvent *event); void paintEvent(QPaintEvent *event) override;
void mouseDoubleClickEvent(QMouseEvent *event); void mouseDoubleClickEvent(QMouseEvent *event) override;
private slots: private slots:
void updateAnimation(); void updateAnimation();

View File

@ -12,11 +12,11 @@ class DiagModel : public QAbstractListModel {
public: public:
explicit DiagModel(QObject *parent = nullptr); explicit DiagModel(QObject *parent = nullptr);
QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const; QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const override;
int columnCount(const QModelIndex &parent) const; int columnCount(const QModelIndex &parent) const override;
int rowCount(const QModelIndex &parent = QModelIndex()) const; int rowCount(const QModelIndex &parent = QModelIndex()) const override;
Qt::ItemFlags flags(const QModelIndex &index) const; Qt::ItemFlags flags(const QModelIndex &index) const override;
QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const; QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
const TagParser::Diagnostics &diagnostics() const; const TagParser::Diagnostics &diagnostics() const;
void setDiagnostics(const TagParser::Diagnostics &diagnostics); void setDiagnostics(const TagParser::Diagnostics &diagnostics);

View File

@ -24,7 +24,7 @@ public:
void editText(const QString &text); void editText(const QString &text);
protected: protected:
virtual void contextMenuEvent(QContextMenuEvent *event); void contextMenuEvent(QContextMenuEvent *event) override;
}; };
} // namespace QtGui } // namespace QtGui

View File

@ -36,7 +36,7 @@ class PicturePreviewSelection : public QWidget {
public: public:
explicit PicturePreviewSelection( explicit PicturePreviewSelection(
TagParser::Tag *tag = nullptr, TagParser::KnownField field = TagParser::KnownField::Invalid, QWidget *parent = nullptr); TagParser::Tag *tag = nullptr, TagParser::KnownField field = TagParser::KnownField::Invalid, QWidget *parent = nullptr);
~PicturePreviewSelection(); ~PicturePreviewSelection() override;
TagParser::Tag *tag() const; TagParser::Tag *tag() const;
TagParser::KnownField field() const; TagParser::KnownField field() const;
@ -64,10 +64,10 @@ signals:
void pictureChanged(); void pictureChanged();
protected: protected:
void changeEvent(QEvent *event); void changeEvent(QEvent *event) override;
void resizeEvent(QResizeEvent *event); void resizeEvent(QResizeEvent *event) override;
void dragEnterEvent(QDragEnterEvent *event); void dragEnterEvent(QDragEnterEvent *event) override;
void dropEvent(QDropEvent *event); void dropEvent(QDropEvent *event) override;
private slots: private slots:
void typeSwitched(int index); void typeSwitched(int index);

View File

@ -26,13 +26,13 @@ class RenameFilesDialog : public QDialog {
public: public:
explicit RenameFilesDialog(QWidget *parent = nullptr); explicit RenameFilesDialog(QWidget *parent = nullptr);
~RenameFilesDialog(); ~RenameFilesDialog() override;
QString directory() const; QString directory() const;
void setDirectory(const QString &directory); void setDirectory(const QString &directory);
protected: protected:
bool event(QEvent *event); bool event(QEvent *event) override;
private slots: private slots:
void showScriptFileSelectionDlg(); void showScriptFileSelectionDlg();

View File

@ -51,7 +51,7 @@ class SettingsDialog : public Dialogs::SettingsDialog {
Q_OBJECT Q_OBJECT
public: public:
explicit SettingsDialog(QWidget *parent = nullptr); explicit SettingsDialog(QWidget *parent = nullptr);
~SettingsDialog(); ~SettingsDialog() override;
}; };
} // namespace QtGui } // namespace QtGui

View File

@ -44,7 +44,7 @@ class TagEditorWidget : public QWidget {
public: public:
explicit TagEditorWidget(QWidget *parent = nullptr); explicit TagEditorWidget(QWidget *parent = nullptr);
~TagEditorWidget(); ~TagEditorWidget() override;
public: public:
bool isFileOperationOngoing() const; bool isFileOperationOngoing() const;
@ -93,7 +93,7 @@ signals:
void fileShown(); void fileShown();
protected: protected:
bool event(QEvent *event); bool event(QEvent *event) override;
private slots: private slots:
// editor // editor

View File

@ -60,7 +60,7 @@ signals:
void returnPressed(); void returnPressed();
protected: protected:
virtual bool eventFilter(QObject *obj, QEvent *event); bool eventFilter(QObject *obj, QEvent *event) override;
private slots: private slots:
void handleRestoreButtonClicked(); void handleRestoreButtonClicked();

View File

@ -18,16 +18,16 @@ public:
void setRootItem(FileSystemItem *rootItem); void setRootItem(FileSystemItem *rootItem);
FileSystemItem *fileSystemItemFromIndex(const QModelIndex &index); FileSystemItem *fileSystemItemFromIndex(const QModelIndex &index);
const FileSystemItem *fileSystemItemFromIndex(const QModelIndex &index) const; const FileSystemItem *fileSystemItemFromIndex(const QModelIndex &index) const;
QVariant data(const QModelIndex &index, int role) const; QVariant data(const QModelIndex &index, int role) const override;
bool setData(const QModelIndex &index, const QVariant &value, int role); bool setData(const QModelIndex &index, const QVariant &value, int role) override;
QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const; QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const override;
QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const; QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const override;
QModelIndex index(FileSystemItem *item, int column = 0) const; QModelIndex index(FileSystemItem *item, int column = 0) const;
QModelIndex parent(const QModelIndex &index) const; QModelIndex parent(const QModelIndex &index) const override;
QModelIndex counterpart(const QModelIndex &index, int column); QModelIndex counterpart(const QModelIndex &index, int column);
int rowCount(const QModelIndex &parent = QModelIndex()) const; int rowCount(const QModelIndex &parent = QModelIndex()) const override;
bool hasChildren(const QModelIndex &parent = QModelIndex()) const; bool hasChildren(const QModelIndex &parent = QModelIndex()) const override;
int columnCount(const QModelIndex &index = QModelIndex()) const; int columnCount(const QModelIndex &index = QModelIndex()) const override;
private: private:
FileSystemItem *m_rootItem; FileSystemItem *m_rootItem;

View File

@ -17,8 +17,8 @@ public:
void setStatusFilter(ItemStatus statusFilter); void setStatusFilter(ItemStatus statusFilter);
protected: protected:
bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const; bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const override;
bool filterAcceptsColumn(int sourceColumn, const QModelIndex &sourceParent) const; bool filterAcceptsColumn(int sourceColumn, const QModelIndex &sourceParent) const override;
private: private:
ItemStatus m_statusFilter; ItemStatus m_statusFilter;