Martchus
/
tageditor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
559 Commits 2 Branches 60 Tags 4.3 MiB
Commit Graph

559 Commits

Author SHA1 Message Date
Martchus 81a9189f56 Update translations 2020-07-07 12:15:56 +02:00
Martchus 5eb5fa463c Fix support for Qt < 5.14 2020-06-11 21:33:06 +02:00
Martchus 61e82c6110 Fix JSON export tests by using jq for the comparison 2020-06-10 18:45:13 +02:00
Martchus ad44ef55ab Use new ButtonOverlay functions for improved behavior of overlay buttons 
See https://github.com/Martchus/tageditor/issues/56
 2020-06-09 23:27:45 +02:00
Martchus 3b9dac469f Mention handling of temporary/backup files in README 2020-06-06 00:17:12 +02:00
Martchus de70f62b24 Don't use deprecated QString::SkipEmptyParts 2020-06-04 20:51:22 +02:00
Martchus bb4bb29ab9 Handle SIGTERM as well (in addition to SIGINT) when saving changes 
* e.g. ffmpeg handles SIGTERM as well to finalize writing the file
* not tested yet
 2020-06-02 17:19:09 +02:00
Martchus fd18fa2bff Update translations 2020-05-13 18:43:57 +02:00
Martchus 20c1d88629 Avoid useless use of QTextStream 2020-05-13 18:42:17 +02:00
Martchus dd3f1f594e Don't use QTextCodec which will be moved to libQt5Compat in Qt 6 2020-05-13 18:41:56 +02:00
Martchus 252b44242a Adapt tests to changes in tagparser 2020-04-26 23:05:15 +02:00
Martchus 0370b1320e Avoid web view appearing as white rectangle when no file is opened 
* Hide web view (and for consistency reglar info view) when no file opened
* The white rectancle is otherwise disturbing when a dark theme is used
 2020-04-26 21:49:01 +02:00
Martchus ed7e93dccf Reduce nesting in MainWindow::fileSelected() 2020-04-26 19:43:27 +02:00
Martchus c05a976bac Apply clang-format 2020-04-24 23:26:52 +02:00
Martchus 01daa21305 Use 'RecordDate' instead of 'Year' field, add 'ReleaseDate' field 2020-04-24 23:26:40 +02:00
Martchus 226ee9f230 Add TODO regarding ID3v2 version 2020-04-24 23:09:24 +02:00
Martchus 4e324f0001 Fix displaying tag values of type DateTime in GUI 2020-04-24 23:08:53 +02:00
Martchus 5027fdd634 Improve README.md 2020-04-24 23:08:23 +02:00
Martchus 17c75114ea Note that setting custom fields works for Opus as well 2020-04-16 20:24:58 +02:00
Martchus c8cbe2852b Add extraction example to CLI documentation 2020-04-16 20:18:37 +02:00
Martchus 911dba870e Improve CLI-only message 2020-04-16 19:52:54 +02:00
Martchus f3ce0f23ec Fix building without GUI 
See https://github.com/Martchus/tageditor/issues/53
 2020-04-05 21:40:12 +02:00
Martchus 976bcbb2e8 Show document title at the top of line edit 
It takes more space but just looks better.
 2020-03-19 16:24:32 +01:00
Martchus 82e8d28bdd Prevent crash when container has no first element 2020-03-18 17:49:02 +01:00
Martchus 67f2802e77 Avoid use of QPalette::PlaceholderText to support Qt < 5.12 
Remove '<colorrole role="PlaceholderText">' elements from UI files
which are apparently added by the designer in newer Qt versions but
break compatibility with older ones.
 2020-03-10 14:59:31 +01:00
Martchus a1d64f95a1 Fix spin box size policy so they are not expanding vertically 2020-03-09 19:05:41 +01:00
Martchus 7ed5723fd9 Use Q_SIGNALS instead of signals 2020-03-09 18:46:08 +01:00
Martchus a927b215bd Set window icon of RenameFilesDialog 2020-03-09 16:10:40 +01:00
Martchus 0f4bbecedc Quit app when closing stand-alone renaming utility 
See https://github.com/Martchus/tageditor/issues/52
 2020-03-09 15:56:48 +01:00
Martchus 3e58d67c4c Don't use lower-case Qt macros 2020-03-08 14:04:29 +01:00
Martchus f6852b2a02 Improve layout of TagEditorWidget 2020-01-11 21:34:46 +01:00
Martchus a4ae94d0b5 Fix adding "required" targets 2019-12-31 01:42:41 +01:00
Martchus 6acf1dbbfa Update translations 2019-12-30 23:54:56 +01:00
Martchus 74afa6e827 Improve canceling 
* Show a specific status messages
* Allow aborting while only the percentage is updated
 2019-12-30 23:54:04 +01:00
Martchus c3275b8bd7 Improve consistency of labels within settings 2019-12-30 22:45:37 +01:00
Martchus 865e461032 Avoid using QAtomicInteger functions deprecated in Qt 5.14.0 2019-12-15 19:31:34 +01:00
Martchus a1b126f18a Fix building against Qt 5.14.0 2019-12-15 19:30:50 +01:00
Martchus 4ad5608484 Reformat CMake scripts against cmake-format 0.6.3 2019-12-15 19:30:00 +01:00
Martchus 9d95bb975a Add licensing info for Windows distribution 2019-11-07 19:04:53 +01:00
Martchus e23cc76d2a Fix lyrics appearing gray 2019-11-03 23:05:35 +01:00
Martchus e7349a4dab Update README.md 2019-10-27 18:51:15 +01:00
Martchus 36655c067f Use override in CliTests 2019-10-27 18:50:56 +01:00
Martchus f228e88c5e Update translations 2019-10-11 20:03:00 +02:00
Martchus 72e918b154 Remove debugging leftover 2019-10-11 19:55:45 +02:00
Martchus 4531d10a81 Move QJSEngine into the thread which executes the JavaScript 
This fixes https://github.com/Martchus/tageditor/issues/50.

When keeping the QJSEngine tied to the main thread the garbage
collector will run on the main thread's event loop. This leads to
crashes when trying to allocate memory within the engine from
another thread (`QV4::PersistentValueStorage::allocate()`).

The Qt documentation does not mention that the garbage collector
might run on the event loop of the thread tied to the JSEngine.
I expected it only to run after or before allocations/deletions
within the thread calling the engine's methods. There is already
an issue regarding the lack of documentation:
https://bugreports.qt.io/browse/QTBUG-57227

I found no way to obtain the QThread object for a thread started
with Qt Concurrent. The possibility I found was calling
`QThread::currentThread()` from the concurrent thread once it has
already been started. However, when the concurrent thread has
been started it might already be too late to move the engine.
Adding further synchronization to solve this is an overkill so
I resorted to using QThread directly.
 2019-10-11 19:47:30 +02:00
Martchus bf4687d0b6 Remove leftovers from old notification system in JS code 
This change was made when already investigating https://github.com/Martchus/tageditor/issues/50.
So that issue was there before this change.
 2019-10-08 18:55:08 +02:00
Martchus bdc1c0d8d9 Update version: 3.3.0 -> 3.3.1 2019-09-27 15:36:57 +02:00
Martchus d92814187a Hide progress indication before showing cover/lyrics dialog 2019-09-25 18:18:06 +02:00
Martchus dc4a6b2ee9 Make "...ApiUrl()" functions static 2019-09-25 18:17:08 +02:00
Martchus 2a9b7eb48a Make LyricsWikia query more robust 
This PR adds a fallback to a self-crafted URL if the XML which is
supposed to contain it broken.

That's required because it seems that the XML is sometimes not
generated correctly (e.g. missing "+" character in song name which
has the plus sign in it).
 2019-09-25 18:16:20 +02:00