Martchus
/
tageditor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
872 Commits 2 Branches 60 Tags 4.3 MiB
Commit Graph

316 Commits

Author SHA1 Message Date
Martchus b4d1df8592 Fix typos found via `codespell --skip .git -w` 2021-07-03 19:38:36 +02:00
Martchus 2a074348fb Remove useless TODO 2021-06-04 16:05:46 +02:00
Martchus a9f3a607a3 Improve showing IO errors 
* Make error messages and dialogs more consistent
* Print the actual error message (which might actually contain something
  useful when NativeFileStream is used)
 2021-06-01 22:36:48 +02:00
Martchus 35ae524bcf Update fallback icons to use Breeze icon theme 2021-05-13 18:24:23 +02:00
Martchus 8258a14089 Use std::vector in PicturePreviewSelection 
The code for handling covers isn't shared between the CLI and Qt GUI yet
but this might make it easier.
 2021-04-28 00:47:55 +02:00
Martchus d31fd79e87 Adapt to changes in tagparser library 2021-04-23 22:18:30 +02:00
Martchus be9ac10372 Make spin boxes (e.g. for BPM) expanding so overlay buttons aren't clipped 2021-04-13 21:24:08 +02:00
Martchus 4c631059ed Avoid implicit conversion 2021-04-07 20:53:32 +02:00
Martchus e535e20720 Fix warnings 2021-03-20 21:59:49 +01:00
Martchus 1a2427d1dc Fix passing/livetime of AbortableProgressFeedback in TagEditorWidget::startParsing() 2021-02-15 23:45:39 +01:00
Martchus e3eff819ec Avoid catchinng all exceptions without re-throwing them 
This shouldn't be required and leads to problems when `pthread_cancel`
would be used: https://udrepper.livejournal.com/21541.html

Note that the tagparser library itself does not contain any `catch (...)`
blocks (which do not re-throw).
 2021-02-11 16:54:18 +01:00
Martchus 9fbb375924 Adapt to changes in tagparser (without making actually use of the new API) 2021-02-04 23:22:43 +01:00
Martchus 16c1d96a28 Avoid nesting in parsing/error handling code 2021-02-02 15:05:45 +01:00
Martchus 670a9a1c91 Adapt to changes in tagparser 2021-01-30 21:57:09 +01:00
Martchus 0d2d79fae6 Apply clang-format 2020-12-16 17:50:03 +01:00
Martchus a85adb3880 Fix Qt 5 build 2020-12-16 17:49:45 +01:00
Martchus e4720ea587 Don't use deprecated QVariant::type() in Qt 6 2020-12-14 21:20:14 +01:00
Martchus 0a7d05256c Adapt to changes in tagparser v10 2020-12-14 21:19:49 +01:00
Martchus 246f4898df Improve FileInfoModel, e.g. use an appropriate unit to show track sizes 2020-11-27 00:15:21 +01:00
Martchus 0a4cbe42aa Allow opening another window 2020-11-25 18:14:40 +01:00
Martchus 596d67387f Improve renaming utility 
* Improve UI
* Add simple example script (the current example script grew quite big and
  is likely not good to get started)
* Add script to format example scripts
 2020-11-25 18:05:23 +01:00
Martchus 7503d51b0d Allow changing focus of lyrics edit via tab key 
* This way it is no longer possible to insert a tab directly but that's
  likely not wanted anyways
* See https://github.com/Martchus/tageditor/issues/59
 2020-10-07 00:27:15 +02:00
Martchus e890a53217 Fix tab order of bottom buttons of tag editor widget 2020-10-07 00:24:22 +02:00
Martchus 14cc42b085 Don't use deprecated '+' operator to make key sequence 2020-09-08 19:38:12 +02:00
Martchus ba34ae38a5 Add custom substitution to auto correction features 2020-09-08 19:37:23 +02:00
Martchus bcefa83c0a Harmonize spelling of tooltips in renaming dialog with other tooltips 2020-09-08 19:12:49 +02:00
Martchus 31904ff084 Support Qt 6 (commit 174154b) 2020-09-04 00:59:22 +02:00
Martchus ad44ef55ab Use new ButtonOverlay functions for improved behavior of overlay buttons 
See https://github.com/Martchus/tageditor/issues/56
 2020-06-09 23:27:45 +02:00
Martchus 20c1d88629 Avoid useless use of QTextStream 2020-05-13 18:42:17 +02:00
Martchus dd3f1f594e Don't use QTextCodec which will be moved to libQt5Compat in Qt 6 2020-05-13 18:41:56 +02:00
Martchus 0370b1320e Avoid web view appearing as white rectangle when no file is opened 
* Hide web view (and for consistency reglar info view) when no file opened
* The white rectancle is otherwise disturbing when a dark theme is used
 2020-04-26 21:49:01 +02:00
Martchus ed7e93dccf Reduce nesting in MainWindow::fileSelected() 2020-04-26 19:43:27 +02:00
Martchus c05a976bac Apply clang-format 2020-04-24 23:26:52 +02:00
Martchus 226ee9f230 Add TODO regarding ID3v2 version 2020-04-24 23:09:24 +02:00
Martchus 976bcbb2e8 Show document title at the top of line edit 
It takes more space but just looks better.
 2020-03-19 16:24:32 +01:00
Martchus 67f2802e77 Avoid use of QPalette::PlaceholderText to support Qt < 5.12 
Remove '<colorrole role="PlaceholderText">' elements from UI files
which are apparently added by the designer in newer Qt versions but
break compatibility with older ones.
 2020-03-10 14:59:31 +01:00
Martchus a1d64f95a1 Fix spin box size policy so they are not expanding vertically 2020-03-09 19:05:41 +01:00
Martchus 7ed5723fd9 Use Q_SIGNALS instead of signals 2020-03-09 18:46:08 +01:00
Martchus a927b215bd Set window icon of RenameFilesDialog 2020-03-09 16:10:40 +01:00
Martchus 0f4bbecedc Quit app when closing stand-alone renaming utility 
See https://github.com/Martchus/tageditor/issues/52
 2020-03-09 15:56:48 +01:00
Martchus 3e58d67c4c Don't use lower-case Qt macros 2020-03-08 14:04:29 +01:00
Martchus f6852b2a02 Improve layout of TagEditorWidget 2020-01-11 21:34:46 +01:00
Martchus a4ae94d0b5 Fix adding "required" targets 2019-12-31 01:42:41 +01:00
Martchus 74afa6e827 Improve canceling 
* Show a specific status messages
* Allow aborting while only the percentage is updated
 2019-12-30 23:54:04 +01:00
Martchus c3275b8bd7 Improve consistency of labels within settings 2019-12-30 22:45:37 +01:00
Martchus e23cc76d2a Fix lyrics appearing gray 2019-11-03 23:05:35 +01:00
Martchus d92814187a Hide progress indication before showing cover/lyrics dialog 2019-09-25 18:18:06 +02:00
Martchus 7f58124bf0 Use aboutToQuit() signal for cleanup-code 
As recommended by the Qt documentation
 2019-09-14 19:44:34 +02:00
Martchus 474d66b25c Improve db query widget 
* Trigger auto-insert also when query results are available
* Allow to refresh when new search criteria has been (automatically)
  inserted

So it is at least a little bit more convenient to use.
 2019-09-03 22:04:43 +02:00
Martchus 76ba02c3c0 Improve context menu of db query widget 2019-09-02 22:13:57 +02:00
Martchus 015dc06c17 Allow to query makeitpersonal.co for lyrics 2019-09-02 21:47:11 +02:00
Martchus a94f2e3675 Improve UI of db query widget 
* Move query options into menu so it is possible to add more
  without being limited by available space
* Trigger the last query action when hitting the enter key
* Change order of elements; I guess it looks better with buttons
  and fields to be used at the top
 2019-09-02 21:42:56 +02:00
Martchus d3f84c4c39 Add conversion from ISO-639-2/B codes to language names 2019-08-17 20:58:14 +02:00
Martchus a5224d930d Apply clang-format 2019-08-13 00:35:04 +02:00
Martchus aa0d57f56a Apply DB query row on double click 2019-08-12 20:27:51 +02:00
Martchus 9c16e22ca8 Ignore case when matching DB query row 2019-08-12 20:27:16 +02:00
Martchus 9fd765c6de Set size policy of cover type selection to minimum expanding 2019-08-12 00:31:41 +02:00
Martchus 570bfc74ac Construct QList for pages from initializer list 2019-08-10 22:04:10 +02:00
Martchus 89ccc39d4b Remove use of fallback icons from qtutilities 
Rely on icons from (bundled) icon theme instead.
 2019-08-08 22:57:30 +02:00
Martchus 865b3501c4 Allow scaling and converting assigned covers 2019-07-21 23:46:46 +02:00
Martchus 955c497a52 Don't abuse organization domain for website in AboutDialog 2019-07-20 20:19:30 +02:00
Martchus 864fd1c901 Fix remaining context menus for Wayland 2019-07-20 18:49:32 +02:00
Martchus 46637093db Remove useless semicolon 2019-07-20 18:42:48 +02:00
Martchus 6c3a230962 Don't use QCursor::pos() for context menu position 
It might now work under Wayland.
 2019-07-20 18:42:32 +02:00
Martchus 376b15a06e Fix warnings in TagEditorWidget::updateDocumentTitleEdits() 2019-07-20 17:59:18 +02:00
Martchus ce0c0c9e19 Workaround lupdate issue 2019-07-07 15:39:24 +02:00
Martchus 72d31c568e Don't use functions obsoleted in Qt 5.13.0 2019-06-25 14:10:31 +02:00
Martchus 940deda0f3 Ensure Qt specific config is included 2019-06-16 15:55:55 +02:00
Martchus 66a45f7578 Adapt to changes in c++utilities 2019-06-12 20:47:44 +02:00
Martchus 66c9250246 Adapt to changes in c++utilities 2019-06-10 22:49:46 +02:00
Martchus 9d175ac316 Add info about automatic insertion from search results 2019-06-01 12:54:22 +02:00
Martchus cf71ac5dca Add info about auto-correction when opening file 2019-06-01 12:53:44 +02:00
Martchus ef82a88a97 Hide empty columns in db query widget 2019-06-01 12:51:11 +02:00
Martchus 52ab1d3f12 Use fromStdString()/toStdString() in AttachmentItem 2019-06-01 12:50:42 +02:00
Martchus 89e3e4b657 Support disk number in db query widget 2019-06-01 12:50:09 +02:00
Martchus de558048ce Use override 2019-06-01 12:45:12 +02:00
Martchus 54315a3739 Use icons which are better distinguishable in file info 2019-06-01 12:40:02 +02:00
Martchus 34a1595641 Improve documentation 2019-05-31 14:02:11 +02:00
Martchus 208c90ef42 Require only one of title and track to match search results 2019-05-31 13:55:36 +02:00
Martchus 777f3b114e Avoid code duplication to determine track number 2019-05-30 14:45:26 +02:00
Martchus ea708f5ad1 Improve tooltips of db query widget 2019-05-30 14:44:54 +02:00
Martchus 456565ceb9 Don't insert song-specific search criteria in db query widget 2019-05-30 14:25:45 +02:00
Martchus 833b96351e Allow locking fields 2019-05-29 00:04:47 +02:00
Martchus 1dbb15dd1c Don't use deprecated Qt features 2019-05-04 22:17:28 +02:00
Martchus f4143a6eb1 Apply cmake-format and clang-format 2019-05-04 21:03:32 +02:00
Martchus 1691b9daa2 Adapt to c++utilities v5 2019-05-04 16:05:20 +02:00
Martchus b1be64fe1d Make LyricWiki URL configurable 2019-04-16 23:10:17 +02:00
Martchus 2ec53c5044 Fix warnings about implicit conversion 2019-03-20 22:29:27 +01:00
Martchus 783d2eb2a6 Hide bitrate if <= zero or NaN 2019-03-10 16:59:15 +01:00
Martchus fb04ee4e12 Reduce code duplication via MediaFileInfo::overallAverageBitrate() 2019-03-10 16:32:56 +01:00
Martchus 849baa8192 Improve message for unsupported field types 2019-02-13 19:09:13 +01:00
Martchus 57396807d5 Show scrollbar for fields if required 2019-02-13 19:08:44 +01:00
Martchus 1e962b8c44 Fix warnings in PicturePreviewSelection 2019-02-13 18:40:47 +01:00
Martchus c2ae237d9b Allow adding cover from clipboard 2019-02-13 18:20:34 +01:00
Martchus 265d8def09 Reduce nesting in code for adding cover 2019-02-13 18:20:08 +01:00
Martchus 6b97860771 Allow to copy selected DB query result 2019-02-13 18:15:49 +01:00
Martchus b19a210fcc Improve coding style 2018-08-20 21:44:47 +02:00
Martchus 42004c8760 Show meta info about cover (size, resolution, MIME-type) 2018-08-20 21:43:50 +02:00
Martchus 1357fd1a32 Adjust DbQueryWidget selection only if empty 2018-08-20 21:41:17 +02:00
Martchus 8e59c5b24f Improve coding style and formatting in dbquery code 2018-08-19 15:11:46 +02:00