Commit Graph

291 Commits

Author SHA1 Message Date
Martchus 860b6f0ea5 Improve wording in about dialog 2022-09-10 16:29:32 +02:00
Martchus 30470c364e Clarify license of breeze icons
This change is similar to recent changes in Syncthing Tray done as part of
Debian packaging.
2022-09-10 16:07:32 +02:00
Martchus b76ccbfc1c Assume by default that tag data types can be treated as string
This makes introducing new tag data types easier as they can usually be
treated as string.
2022-08-13 15:42:52 +02:00
Martchus 82537e5bff Support displaying `TagDataType::DateTimeExpression` 2022-08-13 15:33:55 +02:00
Martchus 507d1ae6d8 Allow renaming currently opened file in GUI 2022-07-29 23:51:32 +02:00
Martchus 77c07d89fa Make all status messages in `TagEditorWidget` translatable 2022-07-29 23:50:28 +02:00
Martchus aa985f69b5 Catch possible exception when closing file 2022-07-29 23:48:35 +02:00
Martchus 95995606cf Allow editing popularity value as string 2022-06-19 16:28:59 +02:00
Martchus 2c6afddee3 Document all member functions of `TagFieldEdit` 2022-06-19 13:46:01 +02:00
Martchus 89bc4535cf Add highlighting for more keywords in renaming utility editor 2022-05-26 21:41:48 +02:00
Martchus cea78543e0 Increase maximum width/height in image conversion dialog
The current limit of 2048 pixels is not *that* big.
2022-05-23 21:46:47 +02:00
Martchus 25458a0ca7 Do not allow changing tag target of Ogg Vorbis comments
It has no effect anyways as tagparser does not allow to move a Vorbis
comment from one stream to another this way.
2022-05-03 23:54:46 +02:00
Martchus 79d9e1b9d4 Fix spelling mistakes 2022-04-12 01:16:27 +02:00
Martchus 4cb728ca48 Restore editability of attachment name in GUI broken by e535e207 2022-04-09 14:25:58 +02:00
Martchus 6577ec161e Make attachments buttons easier to spot on small screens
by simply moving them to the top
2022-04-09 14:21:28 +02:00
Martchus 32c9cbaae2 Use `makeNativePath()` instead of `u8path()`
On non-Windows platforms the internal representation used for paths is the
configured native (narrow) character set. Most of the time that's UTF-8 but
only on Windows UTF-8 is *always* used for the internal representation.
2022-03-17 22:41:51 +01:00
Martchus 7f1e234f36 Fix occurrences of wrong encoding handling with `std::filesystem` 2022-03-16 19:51:54 +01:00
Martchus 2d39875f96 Remove "Custom substitution" checkbox (group checkbox is used instead) 2021-12-31 18:18:00 +01:00
Martchus dfc7b9ebe5 Fix issues when loading file within GUI
* Update file info before creating tags so the file info actually
  represents the file's state on disk
* Fix treating unknown files as MP3 by using the correct flag
  (`TagCreationFlags::TreatUnknownFilesAsMp3Files`)
2021-09-06 18:28:13 +02:00
Martchus 1e084f8eae Add option to preserve "modification date" on file saving for UI
See https://github.com/Martchus/tageditor/issues/67
2021-08-21 01:22:29 +02:00
Martchus 60187d54c8 Reduce indentation in `FileInfoModel::updateCache()` 2021-08-08 00:16:18 +02:00
Martchus ea6e670600 Show only tags which are actually present on disk in the file info view
The file info view is supposed to represent the state of the file as it is
currently on disk and should not show any tags which have been added as
part of the automatic tag management.
2021-08-08 00:07:02 +02:00
Martchus 084bfea1fe Apply changes in `webviewincludes.h` (from `qtutilities`) 2021-08-07 18:29:45 +02:00
Martchus 409582deef Rename "MusicBrains/LyricsWikia search" to "Metadata search"
* LyricsWikia is offline
* "Metadata" is more generic and shorter
2021-08-02 20:10:24 +02:00
Martchus 4701c9c476 Fix removing tag field edit from its current layout causing wrong ordering 2021-07-25 20:36:33 +02:00
Martchus b4d1df8592 Fix typos found via `codespell --skip .git -w` 2021-07-03 19:38:36 +02:00
Martchus 2a074348fb Remove useless TODO 2021-06-04 16:05:46 +02:00
Martchus a9f3a607a3 Improve showing IO errors
* Make error messages and dialogs more consistent
* Print the actual error message (which might actually contain something
  useful when NativeFileStream is used)
2021-06-01 22:36:48 +02:00
Martchus 35ae524bcf Update fallback icons to use Breeze icon theme 2021-05-13 18:24:23 +02:00
Martchus 8258a14089 Use std::vector in PicturePreviewSelection
The code for handling covers isn't shared between the CLI and Qt GUI yet
but this might make it easier.
2021-04-28 00:47:55 +02:00
Martchus d31fd79e87 Adapt to changes in tagparser library 2021-04-23 22:18:30 +02:00
Martchus be9ac10372 Make spin boxes (e.g. for BPM) expanding so overlay buttons aren't clipped 2021-04-13 21:24:08 +02:00
Martchus 4c631059ed Avoid implicit conversion 2021-04-07 20:53:32 +02:00
Martchus e535e20720 Fix warnings 2021-03-20 21:59:49 +01:00
Martchus 1a2427d1dc Fix passing/livetime of AbortableProgressFeedback in TagEditorWidget::startParsing() 2021-02-15 23:45:39 +01:00
Martchus e3eff819ec Avoid catchinng all exceptions without re-throwing them
This shouldn't be required and leads to problems when `pthread_cancel`
would be used: https://udrepper.livejournal.com/21541.html

Note that the tagparser library itself does not contain any `catch (...)`
blocks (which do not re-throw).
2021-02-11 16:54:18 +01:00
Martchus 9fbb375924 Adapt to changes in tagparser (without making actually use of the new API) 2021-02-04 23:22:43 +01:00
Martchus 16c1d96a28 Avoid nesting in parsing/error handling code 2021-02-02 15:05:45 +01:00
Martchus 670a9a1c91 Adapt to changes in tagparser 2021-01-30 21:57:09 +01:00
Martchus 0d2d79fae6 Apply clang-format 2020-12-16 17:50:03 +01:00
Martchus a85adb3880 Fix Qt 5 build 2020-12-16 17:49:45 +01:00
Martchus e4720ea587 Don't use deprecated QVariant::type() in Qt 6 2020-12-14 21:20:14 +01:00
Martchus 0a7d05256c Adapt to changes in tagparser v10 2020-12-14 21:19:49 +01:00
Martchus 246f4898df Improve FileInfoModel, e.g. use an appropriate unit to show track sizes 2020-11-27 00:15:21 +01:00
Martchus 0a4cbe42aa Allow opening another window 2020-11-25 18:14:40 +01:00
Martchus 596d67387f Improve renaming utility
* Improve UI
* Add simple example script (the current example script grew quite big and
  is likely not good to get started)
* Add script to format example scripts
2020-11-25 18:05:23 +01:00
Martchus 7503d51b0d Allow changing focus of lyrics edit via tab key
* This way it is no longer possible to insert a tab directly but that's
  likely not wanted anyways
* See https://github.com/Martchus/tageditor/issues/59
2020-10-07 00:27:15 +02:00
Martchus e890a53217 Fix tab order of bottom buttons of tag editor widget 2020-10-07 00:24:22 +02:00
Martchus 14cc42b085 Don't use deprecated '+' operator to make key sequence 2020-09-08 19:38:12 +02:00
Martchus ba34ae38a5 Add custom substitution to auto correction features 2020-09-08 19:37:23 +02:00