Commit Graph

273 Commits

Author SHA1 Message Date
Martchus dfc7b9ebe5 Fix issues when loading file within GUI
* Update file info before creating tags so the file info actually
  represents the file's state on disk
* Fix treating unknown files as MP3 by using the correct flag
  (`TagCreationFlags::TreatUnknownFilesAsMp3Files`)
2021-09-06 18:28:13 +02:00
Martchus 1e084f8eae Add option to preserve "modification date" on file saving for UI
See https://github.com/Martchus/tageditor/issues/67
2021-08-21 01:22:29 +02:00
Martchus 60187d54c8 Reduce indentation in `FileInfoModel::updateCache()` 2021-08-08 00:16:18 +02:00
Martchus ea6e670600 Show only tags which are actually present on disk in the file info view
The file info view is supposed to represent the state of the file as it is
currently on disk and should not show any tags which have been added as
part of the automatic tag management.
2021-08-08 00:07:02 +02:00
Martchus 084bfea1fe Apply changes in `webviewincludes.h` (from `qtutilities`) 2021-08-07 18:29:45 +02:00
Martchus 409582deef Rename "MusicBrains/LyricsWikia search" to "Metadata search"
* LyricsWikia is offline
* "Metadata" is more generic and shorter
2021-08-02 20:10:24 +02:00
Martchus 4701c9c476 Fix removing tag field edit from its current layout causing wrong ordering 2021-07-25 20:36:33 +02:00
Martchus b4d1df8592 Fix typos found via `codespell --skip .git -w` 2021-07-03 19:38:36 +02:00
Martchus 2a074348fb Remove useless TODO 2021-06-04 16:05:46 +02:00
Martchus a9f3a607a3 Improve showing IO errors
* Make error messages and dialogs more consistent
* Print the actual error message (which might actually contain something
  useful when NativeFileStream is used)
2021-06-01 22:36:48 +02:00
Martchus 35ae524bcf Update fallback icons to use Breeze icon theme 2021-05-13 18:24:23 +02:00
Martchus 8258a14089 Use std::vector in PicturePreviewSelection
The code for handling covers isn't shared between the CLI and Qt GUI yet
but this might make it easier.
2021-04-28 00:47:55 +02:00
Martchus d31fd79e87 Adapt to changes in tagparser library 2021-04-23 22:18:30 +02:00
Martchus be9ac10372 Make spin boxes (e.g. for BPM) expanding so overlay buttons aren't clipped 2021-04-13 21:24:08 +02:00
Martchus 4c631059ed Avoid implicit conversion 2021-04-07 20:53:32 +02:00
Martchus e535e20720 Fix warnings 2021-03-20 21:59:49 +01:00
Martchus 1a2427d1dc Fix passing/livetime of AbortableProgressFeedback in TagEditorWidget::startParsing() 2021-02-15 23:45:39 +01:00
Martchus e3eff819ec Avoid catchinng all exceptions without re-throwing them
This shouldn't be required and leads to problems when `pthread_cancel`
would be used: https://udrepper.livejournal.com/21541.html

Note that the tagparser library itself does not contain any `catch (...)`
blocks (which do not re-throw).
2021-02-11 16:54:18 +01:00
Martchus 9fbb375924 Adapt to changes in tagparser (without making actually use of the new API) 2021-02-04 23:22:43 +01:00
Martchus 16c1d96a28 Avoid nesting in parsing/error handling code 2021-02-02 15:05:45 +01:00
Martchus 670a9a1c91 Adapt to changes in tagparser 2021-01-30 21:57:09 +01:00
Martchus 0d2d79fae6 Apply clang-format 2020-12-16 17:50:03 +01:00
Martchus a85adb3880 Fix Qt 5 build 2020-12-16 17:49:45 +01:00
Martchus e4720ea587 Don't use deprecated QVariant::type() in Qt 6 2020-12-14 21:20:14 +01:00
Martchus 0a7d05256c Adapt to changes in tagparser v10 2020-12-14 21:19:49 +01:00
Martchus 246f4898df Improve FileInfoModel, e.g. use an appropriate unit to show track sizes 2020-11-27 00:15:21 +01:00
Martchus 0a4cbe42aa Allow opening another window 2020-11-25 18:14:40 +01:00
Martchus 596d67387f Improve renaming utility
* Improve UI
* Add simple example script (the current example script grew quite big and
  is likely not good to get started)
* Add script to format example scripts
2020-11-25 18:05:23 +01:00
Martchus 7503d51b0d Allow changing focus of lyrics edit via tab key
* This way it is no longer possible to insert a tab directly but that's
  likely not wanted anyways
* See https://github.com/Martchus/tageditor/issues/59
2020-10-07 00:27:15 +02:00
Martchus e890a53217 Fix tab order of bottom buttons of tag editor widget 2020-10-07 00:24:22 +02:00
Martchus 14cc42b085 Don't use deprecated '+' operator to make key sequence 2020-09-08 19:38:12 +02:00
Martchus ba34ae38a5 Add custom substitution to auto correction features 2020-09-08 19:37:23 +02:00
Martchus bcefa83c0a Harmonize spelling of tooltips in renaming dialog with other tooltips 2020-09-08 19:12:49 +02:00
Martchus 31904ff084 Support Qt 6 (commit 174154b) 2020-09-04 00:59:22 +02:00
Martchus ad44ef55ab Use new ButtonOverlay functions for improved behavior of overlay buttons
See https://github.com/Martchus/tageditor/issues/56
2020-06-09 23:27:45 +02:00
Martchus 20c1d88629 Avoid useless use of QTextStream 2020-05-13 18:42:17 +02:00
Martchus dd3f1f594e Don't use QTextCodec which will be moved to libQt5Compat in Qt 6 2020-05-13 18:41:56 +02:00
Martchus 0370b1320e Avoid web view appearing as white rectangle when no file is opened
* Hide web view (and for consistency reglar info view) when no file opened
* The white rectancle is otherwise disturbing when a dark theme is used
2020-04-26 21:49:01 +02:00
Martchus ed7e93dccf Reduce nesting in MainWindow::fileSelected() 2020-04-26 19:43:27 +02:00
Martchus c05a976bac Apply clang-format 2020-04-24 23:26:52 +02:00
Martchus 226ee9f230 Add TODO regarding ID3v2 version 2020-04-24 23:09:24 +02:00
Martchus 976bcbb2e8 Show document title at the top of line edit
It takes more space but just looks better.
2020-03-19 16:24:32 +01:00
Martchus 67f2802e77 Avoid use of QPalette::PlaceholderText to support Qt < 5.12
Remove '<colorrole role="PlaceholderText">' elements from UI files
which are apparently added by the designer in newer Qt versions but
break compatibility with older ones.
2020-03-10 14:59:31 +01:00
Martchus a1d64f95a1 Fix spin box size policy so they are not expanding vertically 2020-03-09 19:05:41 +01:00
Martchus 7ed5723fd9 Use Q_SIGNALS instead of signals 2020-03-09 18:46:08 +01:00
Martchus a927b215bd Set window icon of RenameFilesDialog 2020-03-09 16:10:40 +01:00
Martchus 0f4bbecedc Quit app when closing stand-alone renaming utility
See https://github.com/Martchus/tageditor/issues/52
2020-03-09 15:56:48 +01:00
Martchus 3e58d67c4c Don't use lower-case Qt macros 2020-03-08 14:04:29 +01:00
Martchus f6852b2a02 Improve layout of TagEditorWidget 2020-01-11 21:34:46 +01:00
Martchus a4ae94d0b5 Fix adding "required" targets 2019-12-31 01:42:41 +01:00