Commit Graph

1174 Commits

Author SHA1 Message Date
Martchus e388f72b97 WIP: Use Boost.Stacktrace to print a stacktrace in case of unhandled errors 2021-10-20 22:18:03 +02:00
Martchus be92d5366c Show name instead of ID in recent changes
See https://github.com/Martchus/syncthingtray/issues/115
2021-10-19 23:35:28 +02:00
Martchus 5ef0523458 Remove icons which are no longer needed 2021-10-16 21:28:59 +02:00
Martchus 19bede39a2 Simplify coloring of common ForkAwesome icons
The normal QPalette can be used to determine the icon color so it is
unnecessary to use the flag for custom bright colors here (which is only
intended for colors which are not on the standard QPalette).
2021-10-16 21:20:12 +02:00
Martchus de3205df00 Use ForkAwesome icons also in RecentChangesPage of Plasmoid 2021-10-15 23:16:58 +02:00
Martchus 4dc9f08639 Update translations 2021-10-15 22:21:40 +02:00
Martchus 9e3cd95b13 Apply clang-format 2021-10-15 22:18:54 +02:00
Martchus 0651323da4 Use ForkAwesome consistently in Plasmoid as well 2021-10-15 22:18:30 +02:00
Martchus 7b6121cb05 Use ForkAwesome icons more consistently in tray widget
Mixing ForkAwesome icons too much with the regular icon theme doesn't look
good (depending on the theme) so let's prefer ForkAwesome icons within the
tray widget which already uses ForkAwesome in some places like certain
buttons and models. This makes it also look more in-line with Syncthing's
web UI. For context menus and dialogs let's prefer system icons because
there are hardly any ForkAwesome icons used/required so far and it is maybe
nicer to be in-line with the system here.
2021-10-15 00:23:22 +02:00
Martchus d3c878359a Fix typo in libsyncthing tests 2021-10-13 00:14:49 +02:00
Martchus 3b50d78f1e Use resource lock to avoid concurrent execution of tests requiring Syncthing test instance
This is likely the cleaner approach compared to just enforcing a serial run
for the CLI test.
2021-10-13 00:14:35 +02:00
Martchus 1f74a82ecb Adapt test for loading self-signed certificate 2021-10-12 23:55:17 +02:00
Martchus 6c23bb6e82 Avoid running CLI and connector tests in parallel
* Fix the test execution when parallel ctest jobs are configured
  via e.g. `CTEST_PARALLEL_LEVEL`
* See https://github.com/Martchus/syncthingtray/issues/116
2021-10-12 23:40:35 +02:00
Martchus 09d5c5589e Add missing verb in `plasmoid/testing.md` 2021-10-10 23:22:34 +02:00
Martchus 3bf50fb414 Use Syncthing icon from ForkAwesome for buttons/menus
This should look more consistent than abusing the state-specific "idling"
icon.
2021-10-10 20:44:22 +02:00
Martchus 77f0a8d5ae Update translations 2021-10-09 01:15:49 +02:00
Martchus 0b801bc505 Make internal errors also accessible when starting with `--windowed`
* Show the button for the internal errors dialog in the tray widget like it
  is done when the `UNIFY_TRAY_MENUS` config is activated
2021-10-09 01:14:54 +02:00
Martchus c63719e2d1 Check whether loaded certificate is not null 2021-10-09 01:14:54 +02:00
Martchus 3c6716ebb9 Expect more TLS error types to support Schannel backend
Apparently the Schannel backend also produces
`QSslError::CertificateUntrusted` errors. Also adding
`QSslError::CertificateRejected` to be sure.
2021-10-09 01:14:54 +02:00
Martchus ab605049aa Improve TLS error messages
* Add fallback to .toPem() when .toText() is not implemented by the TLS
  plugin
* Add error number (Qt's enum value)
* Remove leftover cerr logging
2021-10-09 01:14:54 +02:00
Martchus feb7fb04db Apply clang-format in `fileitemactionplugin/CMakeLists.txt` 2021-10-08 22:54:30 +02:00
Martchus c3182ff256 Apply cmake-format 2021-10-07 18:28:13 +02:00
Martchus b49d51cc44 Bump patch version 2021-10-07 18:22:41 +02:00
Martchus 8b273b6945 Improve messages for TLS errors
Before one only gets the generic error "TLS handshake failed". Now one gets
more details error messages plus the problematic certificate. This should
be helpful for debugging.
2021-10-07 18:22:41 +02:00
Martchus af24ead784 Use ISO format for timestamps and put it in square brackets when displaying errors 2021-10-07 18:22:41 +02:00
Martchus 8f59dc12d3
Merge pull request #114 from coxde/zh_CN
Add zh_CN translation
2021-10-06 20:19:15 +02:00
Julianne420 ddefa35daa Add zh_CN translation 2021-10-07 01:20:24 +08:00
Martchus cf99b656f0 Link against the qtforkawesomeiconengine plugin when it is a static library
This should fix the AppImage build where my own libraries (including
plugins) are built as static libraries but static linkage is not generally
enabled.
2021-10-06 17:19:15 +02:00
Martchus 4801afebf5 Fix references to README section "Known bugs and workarounds" 2021-10-06 17:07:27 +02:00
Martchus cd636c9da8 Add notes about Windows' per-monitor DPI awareness (V2) 2021-10-05 18:16:10 +02:00
Martchus feb8034b74 Remove section about planned features from README
There's no fix plan for implementing any of these features which should be
better tracked as issues anyways.
2021-10-05 18:15:26 +02:00
Martchus e3a69a514c Fix typo in README 2021-10-05 18:14:16 +02:00
Martchus e03d276c93 Add notes about compatibility of Windows builds 2021-10-05 18:14:04 +02:00
Martchus fe4e9899d7 Update libsyncthing to v1.18.3 2021-10-05 18:13:05 +02:00
Martchus 8348648c56 Make c'tor of `InternalError` inline again to workaround linker errors
Otherwise the shared build with targeting x86_64-w64-mingw32 fails with:

```
FAILED: widgets/syncthingwidgets-qt6.dll widgets/libsyncthingwidgets-qt6.dll.a
: && /usr/lib/ccache/bin/x86_64-w64-mingw32-g++ -D_FORTIFY_SOURCE=2 -D_GLIBCXX_ASSERTIONS  -D_FORTIFY_SOURCE=2 -D_GLIBCXX_ASSERTIONS -O2 -pipe -fno-plt -fexceptions --param=ssp-buffer-size=4 -Wformat -Werror=format-security -fcf-protection -O3 -DNDEBUG  -Wl,-O1,--sort-common,--as-needed -fstack-protector -shared -o widgets/syncthingwidgets-qt6.dll -Wl,--out-implib,widgets/libsyncthingwidgets-qt6.dll.a -Wl,--major-image-version,1,--minor-image-version,1 widgets/CMakeFiles/syncthingwidgets-qt6.dir/syncthingwidgets-qt6_autogen/mocs_compilation.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/settings/settings.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/settings/settingsdialog.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/webview/webpage.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/webview/webviewdialog.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/webview/webviewinterceptor.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/textviewdialog.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/internalerrorsdialog.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/direrrorsdialog.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/statusinfo.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/dbusstatusnotifier.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/internalerror.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/otherdialogs.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/syncthinglauncher.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/syncthingkiller.cpp.obj widgets/CMakeFiles/syncthingwidgets-qt6.dir/resources/windows-Release.rc.res widgets/CMakeFiles/syncthingwidgets-qt6.dir/syncthingwidgets-qt6_autogen/3YJK5W5UP7/qrc_syncthingwidgetsicons.cpp.obj -L/build/mingw-w64-syncthingtray-qt6/src/syncthingtray/build-x86_64-w64-mingw32-shared/connector   -L/build/mingw-w64-syncthingtray-qt6/src/syncthingtray/build-x86_64-w64-mingw32-shared/model   -L/build/mingw-w64-syncthingtray-qt6/src/lib model/libsyncthingmodel-qt6.dll.a  /usr/x86_64-w64-mingw32/lib/libqtutilities-qt6.dll.a  libsyncthing/libsyncthing-qt6.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Network.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Concurrent.dll.a  connector/libsyncthingconnector-qt6.dll.a  /usr/x86_64-w64-mingw32/lib/libc++utilities.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Network.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Core.dll.a  /usr/x86_64-w64-mingw32/lib/libqtforkawesome-qt6.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Widgets.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Gui.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Core.dll.a  /usr/x86_64-w64-mingw32/lib/libc++utilities.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Widgets.dll.a  /usr/x86_64-w64-mingw32/lib/libQt6Gui.dll.a  -ld3d11  -ldxgi  -ldxguid  -lws2_32  /usr/x86_64-w64-mingw32/lib/libQt6Core.dll.a  -lmpr  -luserenv  -lkernel32 -luser32 -lgdi32 -lwinspool -lshell32 -lole32 -loleaut32 -luuid -lcomdlg32 -ladvapi32 && :
/usr/lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld: widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/internalerror.cpp.obj:internalerror.cpp:(.text+0x1a0): multiple definition of `QtGui::InternalError::InternalError(QString const&, QUrl const&, QByteArray const&)'; widgets/CMakeFiles/syncthingwidgets-qt6.dir/syncthingwidgets-qt6_autogen/mocs_compilation.cpp.obj:mocs_compilation.cpp:(.text$_ZN5QtGui13InternalErrorC2ERK7QStringRK4QUrlRK10QByteArray[_ZN5QtGui13InternalErrorC2ERK7QStringRK4QUrlRK10QByteArray]+0x0): first defined here
/usr/lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld: widgets/CMakeFiles/syncthingwidgets-qt6.dir/misc/internalerror.cpp.obj:internalerror.cpp:(.text+0x1a0): multiple definition of `QtGui::InternalError::InternalError(QString const&, QUrl const&, QByteArray const&)'; widgets/CMakeFiles/syncthingwidgets-qt6.dir/syncthingwidgets-qt6_autogen/mocs_compilation.cpp.obj:mocs_compilation.cpp:(.text$_ZN5QtGui13InternalErrorC1ERK7QStringRK4QUrlRK10QByteArray[_ZN5QtGui13InternalErrorC1ERK7QStringRK4QUrlRK10QByteArray]+0x0): first defined here
```

I can currently not make sense of this build error. It does not happen
when targeting Linux or i686.
2021-10-05 00:13:34 +02:00
Martchus 4301910f1d Avoid `QMessageBox::warning()` overload deprecated by Qt 6.2.0 2021-10-04 19:31:50 +02:00
Martchus 567e176d48 Link libsyncthing to pthread library via `-pthread`
That's preferred over just specifying the library path because it invokes
additional behavior like adding `-D_REENTRANT` which might be required.
2021-10-04 19:21:18 +02:00
Martchus 55e59d20c0 Make c'tor of InternalError explicit 2021-10-04 19:17:33 +02:00
Martchus 5e50d25c32 Improve build instructions
* Remove `-DBUNDLED_QT_FORK_AWESOME_PATH=…` which is now covered by the
  subdirs project
* Add link to "Providing the font file" section
2021-10-03 23:17:31 +02:00
Martchus 52217814f1 Apply cmake-format 2021-10-03 23:07:12 +02:00
Martchus 8261a161ab Set default re-connect interval back to 30 seconds
See https://github.com/Martchus/syncthingtray/issues/16#issuecomment-932986686
2021-10-03 23:05:49 +02:00
Martchus 98c911b2f8
Merge pull request #113 from hrittich/upstream-patches
Allow finding of packages in namespaces
2021-10-03 19:55:55 +02:00
Hannah Rittich 2968898195 Allow finding of packages in namespaces 2021-10-03 02:07:18 +02:00
Martchus 4517ea41b6 Update translations 2021-10-02 20:31:56 +02:00
Martchus 745082f357 Redact password from URL when displaying internal errors 2021-10-02 20:31:20 +02:00
Martchus 239d751342 Avoid an unhandled exception when local setup is incorrect
Apparently Boost.Process relies on the setup to be correct so the
configured locale actually needs to be available.
2021-09-30 23:41:27 +02:00
Martchus b0a17cc540
Merge pull request #112 from tomasz1986/tomasz86-classic2000
Add link to Classic 2000 custom high contrast Windows themes
2021-09-25 19:13:34 +02:00
Tomasz Wilczyński 093f42cb38
Add link to Classic 2000 custom high contrast Windows themes
Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
2021-09-26 01:22:20 +09:00
Martchus e73350c982 Mention "High contrast" option in dark mode workaround 2021-09-17 22:39:13 +02:00
Martchus 44d69cd3bf Remove the dark stylesheet as it is not working well and a different palette is enough 2021-09-17 22:23:29 +02:00