Martchus
/
tageditor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
633 Commits 2 Branches 60 Tags 4.3 MiB
Commit Graph

633 Commits

Author SHA1 Message Date
Martchus b4d1df8592 Fix typos found via `codespell --skip .git -w` 2021-07-03 19:38:36 +02:00
Martchus ebf52dcf15 Update translations 2021-06-04 16:06:21 +02:00
Martchus 2a074348fb Remove useless TODO 2021-06-04 16:05:46 +02:00
Martchus 28cc7ac1da Apply clang-format 2021-06-03 23:18:20 +02:00
Martchus 39870dd8e2 Link against a possibly required extra library for std::filesystem 2021-06-03 23:15:51 +02:00
Martchus a9f3a607a3 Improve showing IO errors 
* Make error messages and dialogs more consistent
* Print the actual error message (which might actually contain something
  useful when NativeFileStream is used)
 2021-06-01 22:36:48 +02:00
Martchus 523971ad9d Suppress warning about cover type for ID3v1 tag when also an ID3v2 tag is present 2021-06-01 22:05:07 +02:00
Martchus 7ada28b06e cli: Allow preserving the modification time 
See https://github.com/Martchus/tageditor/issues/66
 2021-06-01 21:56:23 +02:00
Martchus 43eaf7f8db Update TODOs section of README and merge it with Windows problems 
* Drop the note about `-DUSE_NATIVE_FILE_BUFFER=ON` because this is now the
  default and mentioned in c++utilities itself.
 2021-05-31 20:16:00 +02:00
Martchus 91c854b83b Bump minor version 
The `--quiet` flag has been added and some bugs have been fixed which
prevented certain features to work at all.
 2021-05-27 19:00:42 +02:00
Martchus 53bb9fb292 Update translations 2021-05-27 18:58:24 +02:00
Martchus 3203d4403e Apply clang-format 2021-05-27 18:56:53 +02:00
Martchus 9e0ce80c8c cli: Add --quiet flag to set operation 2021-05-27 18:56:42 +02:00
Martchus 818b9a60f6 Add test for setting field value from file 2021-05-27 18:31:27 +02:00
Martchus 53f0f02c72 Fix handling arbitrary files specified as field values 
The container offset must not be used here as it may be garbage if the file
format is not recognized (e.g. if the file is an arbitrary text file).
 2021-05-22 23:02:55 +02:00
Martchus 54093af53b Add missing include for std::optional 2021-05-22 22:59:52 +02:00
Martchus 35ae524bcf Update fallback icons to use Breeze icon theme 2021-05-13 18:24:23 +02:00
Martchus c238900fe3 Add test for modifying cover via CLI 2021-05-10 21:32:00 +02:00
Martchus 0aa8c53252 Add remark about the GUI and multiple values per field to README.md 2021-05-10 20:55:58 +02:00
Martchus 5acb9d32ee Show the cover description within the CLI 2021-05-10 20:51:50 +02:00
Martchus 1944773022 Allow setting multiple covers of the same type but different descriptions 
The standard actually says that there might be different covers with only
different descriptions:

    Description is a
    short description of the picture, represented as a terminated
    text string. There may be several pictures attached to one file, each
    in their individual "APIC" frame, but only one with the same content
    descriptor. There may only be one picture with the picture type
    declared as picture type $01 and $02 respectively.

I assume "content descriptor" means combination of the type and
description.

This is in accordance with eyeD3.

See https://github.com/Martchus/tageditor/issues/64#issuecomment-833952940
 2021-05-10 20:51:15 +02:00
Martchus 49b0cdb1cd Don't print jq invocation when running tests by default as it is very long 2021-04-28 17:49:19 +02:00
Martchus b56232c1f4 Fix printing cover field of non-ID3v2 tags 2021-04-28 17:48:29 +02:00
Martchus 41fb2069f3 Allow setting covers of special types with description via CLI 
See https://github.com/Martchus/tageditor/issues/64
 2021-04-28 00:57:57 +02:00
Martchus 8258a14089 Use std::vector in PicturePreviewSelection 
The code for handling covers isn't shared between the CLI and Qt GUI yet
but this might make it easier.
 2021-04-28 00:47:55 +02:00
Martchus d31fd79e87 Adapt to changes in tagparser library 2021-04-23 22:18:30 +02:00
Martchus be9ac10372 Make spin boxes (e.g. for BPM) expanding so overlay buttons aren't clipped 2021-04-13 21:24:08 +02:00
Martchus 4c631059ed Avoid implicit conversion 2021-04-07 20:53:32 +02:00
Martchus e535e20720 Fix warnings 2021-03-20 21:59:49 +01:00
Martchus 8158ef930a Add note about old Qt versions and support for modern JavaScript features 2021-02-16 01:16:58 +01:00
Martchus 7f3fc590d7 Use String.prototype.padStart() in renaming utility examples 2021-02-16 01:13:34 +01:00
Martchus 4d3eff3455 Extend renaming utility example to move tracks into for dirs for ranges 2021-02-16 01:02:03 +01:00
Martchus 1a2427d1dc Fix passing/livetime of AbortableProgressFeedback in TagEditorWidget::startParsing() 2021-02-15 23:45:39 +01:00
Martchus e3eff819ec Avoid catchinng all exceptions without re-throwing them 
This shouldn't be required and leads to problems when `pthread_cancel`
would be used: https://udrepper.livejournal.com/21541.html

Note that the tagparser library itself does not contain any `catch (...)`
blocks (which do not re-throw).
 2021-02-11 16:54:18 +01:00
Martchus 89a85184c3 Improve build instructions in README.md 2021-02-07 15:36:24 +01:00
Martchus 9fbb375924 Adapt to changes in tagparser (without making actually use of the new API) 2021-02-04 23:22:43 +01:00
Martchus 16c1d96a28 Avoid nesting in parsing/error handling code 2021-02-02 15:05:45 +01:00
Martchus 82d0834e75 Adapt to changes in tagparser 2021-02-02 11:02:30 +01:00
Martchus 7ed99a5035 Adapt to changes in tagparser 2021-02-01 17:11:48 +01:00
Martchus 670a9a1c91 Adapt to changes in tagparser 2021-01-30 21:57:09 +01:00
Martchus 06fd8c58d7 Fix invocation of write in interrupt handler 2021-01-30 21:54:59 +01:00
Martchus c4595f4035 Note LyricWiki shutdown 2021-01-30 21:54:14 +01:00
Martchus 0d2d79fae6 Apply clang-format 2020-12-16 17:50:03 +01:00
Martchus a85adb3880 Fix Qt 5 build 2020-12-16 17:49:45 +01:00
Martchus e4720ea587 Don't use deprecated QVariant::type() in Qt 6 2020-12-14 21:20:14 +01:00
Martchus 0a7d05256c Adapt to changes in tagparser v10 2020-12-14 21:19:49 +01:00
Martchus 28b038e5d8 Mark overriding functions of TargetLevelModel 2020-12-10 19:13:50 +01:00
Martchus 0f2afd3aea Improve download section of README 2020-12-05 21:30:53 +01:00
Martchus f7bcefe0d1 Allow building against tagparser 10 2020-12-05 21:10:43 +01:00
Martchus 131772f1df Update RPM download section 2020-12-05 21:07:47 +01:00